Elevate Windows CI to /W3 (sans C4018/C4267) #17665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C4018[1] is about unsigned/signed comparisons; C4267[2] is about conversion from `size_t` to a "smaller" type. We likely should resolve these warnings in the long run, but for now, it seems like a no brainer to elevate to `/W3` even if we have to exempt two additional categories of warnings, since we can catch some others. And we no longer need to elevate C4010[3] to a higher level to catch it. [1] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4018> [2] <https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267> [3] <https://learn.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4013>
mvorisek
reviewed
Feb 2, 2025
| @@ -32,7 +32,7 @@ if "%THREAD_SAFE%" equ "0" set ADD_CONF=%ADD_CONF% --disable-zts | |||
| if "%INTRINSICS%" neq "" set ADD_CONF=%ADD_CONF% --enable-native-intrinsics=%INTRINSICS% | |||
| if "%ASAN%" equ "1" set ADD_CONF=%ADD_CONF% --enable-sanitizer --enable-debug-pack | |||
|
|
|||
| set CFLAGS=/W2 /WX /w14013 /wd4146 /wd4244 | |||
| set CFLAGS=/W3 /WX /wd4018 /wd4146 /wd4244 /wd4267 | |||
There was a problem hiding this comment.
short comments above what these "numbers" are would greatly improve the readability
There was a problem hiding this comment.
Done. But I'm not 100% sure that makes much sense. One still needs to know what /W3 implies, and as such might need to look up the warnings "all the time". In my opinion, gcc and clang handle this much better.
|
Do you have a list for the cases that trigger |
After applying win32/ioutil.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/win32/ioutil.h b/win32/ioutil.h
index 8b9ed491ff..83c9b397f9 100644
--- a/win32/ioutil.h
+++ b/win32/ioutil.h
@@ -227,7 +227,7 @@ zend_always_inline static wchar_t *php_win32_ioutil_conv_any_to_w(const char* in
memcpy(ret, PHP_WIN32_IOUTIL_LONG_PATH_PREFIXW, PHP_WIN32_IOUTIL_LONG_PATH_PREFIX_LENW * sizeof(wchar_t));
#ifndef ZTS
if (dir_len > 0) {
- size_t len = GetCurrentDirectoryW(dir_len, dst);
+ size_t len = GetCurrentDirectoryW((DWORD) dir_len, dst);
if (len == 0 || len + 1 != dir_len) {
free(ret);
free(mb);the list is "managable": C4267 warnings (x64)
Understandable. There are sooo many issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C4018[1] is about unsigned/signed comparisons; C4267[2] is about conversion from
size_tto a "smaller" type. We likely should resolve these warnings in the long run, but for now, it seems like a no brainer to elevate to/W3even if we have to exempt two additional categories of warnings, since we can catch some others. And we no longer need to elevate C4010[3] to a higher level to catch it.[1] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4018
[2] https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267
[3] https://learn.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4013